-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLite extension loading via sqlx.toml for CLI and query macros #3713
base: sqlx-toml
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very keen in landing this, but besides fixing the build, it does also need some sort of test to prove that it works, and ideally a compile-checked example that shows how to use it. In #3383 I realized I could take out two birds with one stone by adding some example projects showing off the new configuration. I'd suggest doing the same.
(I'm just now realizing the build failures are from #3383 itself so disregard that.) |
…oes not already exist
I'll be happy to add an example, but there's a complication: to demonstrate this functionality, it's necessary to load a SQLite extension, and that requires that the example is dependent on having that extension installed. Are you okay with having an example that has a third-party dependency which is not shipped with SQLx? If so, what is your preference for how I structure that? |
Our CI already downloads an extension from https://github.com/nalgeon/sqlean/ for testing: sqlx/.github/workflows/sqlx.yml Line 125 in 65229f7
One thing is that for Unix platforms, you need to show the user either how to set |
fixes issue #3330 by allowing the query checking macros to load SQLite extensions specified in sqlx.toml.
Related to that, also allows the CLI to load the SQLite extensions specified in sqlx.toml when running migrations